fix: self type replacement in inline-function #16114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16113, fix #16091
The problem described in this issue actually involves three bugs.
Firstly, when using
ted
to modify the syntax tree, the offset of nodes on the tree changes, which causes the syntax range information fromhir
to become invalid. Therefore, we need to edit the AST after the last usage forusages_for_locals
.The second issue is that when inserting nodes, it's necessary to use
clone_subtree
for duplication because theted::replace
operation essentially moves a node.The third issue is that we should use
ancestors_with_macros
instead ofancestors
to handle impl definition in macros.I have fixed the three bugs mentioned above and added unit tests.