Debug test lens

[hdevalke]

I am the maintainer of the Rust Test Lens extension in vscode.

Issue 17 was created because it was not possible to debug crates that contain a main.rs and a lib.rs in the same project. I cannot solve that problem without parsing the rust code.

As a proof of concept I tried to implement this in rust-analyzer see: hdevalke@2e2ad8c.

Do you think it makes sense to integrate this in rust-analyzer, knowing that currently it depends on the vscode-lldb extension?

[Veetaha]

Hi! Thank you for the awesome extension! It does help a lot to debug rust-analyzer tests itself!

I personally don't see any impediments to merge the PoC, since rust-analyzer is not likely to replace lldb extension and is rather to be used in combination with it.
We had some discussion on this topic with @matklad at this zulip thread.

[matklad]

Yup, we should just do that, thanks for exploring this @hdevalke!

Although, impl-wise, I think we should try to avoid providing separate debug/run commands, and instead have a single command which can be both debugged and runed. Ie, instead of introducing DebugConfiguration, I would rather tweak Runnable two contain both the info required for run, and the info required for debug.

[matklad]

We also should upstream this to the LSP/VS Code. There should be a proper protocol request for telling which things can be run from a given context....

[matklad]

Opened microsoft/language-server-protocol#944 upstream

[hdevalke]

Hi @matklad,

You are right sharing a common structure for debugging or running should work as well.
I did split up the args into args and extra_args because that's what the vscode-lldb debug configuration expects it and I did not had to search for -- in the args vector.

The only difference between runnable and debug configuration is:
for non bin targets: add --no-run, for bin target replace run with build.

I made a new commit using only the modified Runnable struct: 0714a06...hdevalke:debug-lens.

To make this user friendly there is probably some need to add vscode-lldb as an extension dependency, or show a popup to propose to install vscode-lldb if debug.startDebugging returned false.

[matklad]

yes, it's fine to add vscode-lldb as a dependency of rust-analyzer

[hdevalke]

@matklad @Veetaha thanks for helping me to add this functionality to rust-analyzer. It has been a pleasure to work with you.