Skip to content

Change new attribute syntax highlighting color #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cart opened this issue May 25, 2020 · 3 comments
Closed

Change new attribute syntax highlighting color #4613

cart opened this issue May 25, 2020 · 3 comments
Labels
E-easy S-actionable Someone could pick this issue up and work on it right now

Comments

@cart
Copy link

cart commented May 25, 2020

I think #4474 is a good change, but im not a huge fan of coloring attributes as functions. I liked that attributes were "distinct" from function calls. My brain now mentally groups attributes and their functions as "the same":

image

I personally think the old coloring was much clearer.

Ideally it would use a different color that still visually groups with the concept of "attribute". Maybe a slightly lighter or darker version of the attribute color?

image

@matklad
Copy link
Member

matklad commented May 26, 2020

We can't control the color, but we can and probably should produce a dedicated semantic highlighting tag for attribute attr key.

@ruabmbua
Copy link
Contributor

ruabmbua commented Jun 1, 2020

You an customize the color yourself:

"editor.semanticTokenColorCustomizations": {
        "[Default Dark+]": {
            "enabled": true,
            "rules": {
                "function.attribute": "#9b9809",
            },
        }
    },

@matklad matklad added the E-easy label Jul 11, 2020
@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Oct 14, 2020
@Veykril
Copy link
Member

Veykril commented Mar 21, 2021

I believe we can close this, for #[inline] the inline is tagged as function.attribute and the #[ and ] parts are tagged as attribute.attribute which should give appropriate coloring options.

@Veykril Veykril closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

5 participants