Color attribute functions #4474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewfraser
force-pushed
the
color_attrs
branch
from
3e1e3b9 to
47ce5ea
Compare
|
@matklad LGTM |
|
bors r+ |
matklad
reviewed
May 24, 2020
| @@ -361,7 +361,9 @@ fn highlight_element( | |||
| } | |||
|
|
|||
| // Highlight references like the definitions they resolve to | |||
| NAME_REF if element.ancestors().any(|it| it.kind() == ATTR) => return None, | |||
| NAME_REF if element.ancestors().any(|it| it.kind() == ATTR) => { | |||
| Highlight::from(HighlightTag::Function) | HighlightModifier::Attribute | |||
There was a problem hiding this comment.
I guess, this gives a nicer looks, but semantically this feels wrong. Like, it's not a function, it's a part of attribute syntax.
Maybe we should introduce something like HighlightTag::AttrKey here? Not that it really matters though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, only literals are colored within Rust attributes:
To me, attributes look weirdly blank, and it seems like we should make some attempt to color them. I gathered some feedback on Zulip and in #4430. This PR colors the outer function that's present in every attribute as a function:
I think this will be an uncontroversial improvement. I think it would also be popular if we colored type names in
#[derive(TypeName)], and perhaps some other special cases, but this would require ad-hoc special cases inrust-analyzer, which might be controversial, so I'm starting with the most obvious improvements in this PR.Fixes #4430