Skip to content

Top level attribtues are completed inside nested attributes #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matklad opened this issue Jun 15, 2020 · 4 comments · Fixed by #4899
Closed

Top level attribtues are completed inside nested attributes #4890

matklad opened this issue Jun 15, 2020 · 4 comments · Fixed by #4899
Labels
E-easy E-has-instructions Issue has some instructions and pointers to code to get started

Comments

@matklad
Copy link
Member

matklad commented Jun 15, 2020

image

image

Also, the label here should probably say deprecated = "...", it's better to give visual clues about what would be inserted.

The relevant code & tests are here: https://github.com/rust-analyzer/rust-analyzer/blob/672d160b013df82b1729fd3db130ff7b6f9b5b31/crates/ra_ide/src/completion/complete_attribute.rs
@matklad matklad added E-easy E-has-instructions Issue has some instructions and pointers to code to get started labels Jun 15, 2020
@bnjjj
Copy link
Contributor

bnjjj commented Jun 15, 2020

Will solve this :)

bnjjj added a commit to bnjjj/rust-analyzer that referenced this issue Jun 15, 2020
@bnjjj
don't complete top level attrs inside nested attrs and add better lab…
9aad07d 
…els rust-lang#4890

Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj mentioned this issue Jun 15, 2020
Merged
@abreis
Copy link

abreis commented Jun 16, 2020 •
edited
Loading

different issue, now #4907

@bnjjj
Copy link
Contributor

bnjjj commented Jun 16, 2020

@abreis Hmm I think here you're talking about keywords and not attributes

@abreis
Copy link

abreis commented Jun 16, 2020

Doh, you're right. Nevermind.

bnjjj added a commit to bnjjj/rust-analyzer that referenced this issue Jun 18, 2020
@bnjjj
don't complete top level attrs inside nested attrs and add better lab…
3f26c57 
…els rust-lang#4890

Signed-off-by: Benjamin Coenen <[email protected]>
@bors bors bot closed this as completed in d8842e8 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy E-has-instructions Issue has some instructions and pointers to code to get started
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't complete top level attrs inside nested attrs and add better labels bnjjj/rust-analyzer
3 participants
@abreis @matklad @bnjjj