Error on DMatrix::zeros(rows, cols)

[vadixidav]

For me (on current weekly version), this version introduced a regression that causes DMatrix to be picked up incorrectly when using DMatrix::zeros(). It claims that there is no arguments:

However, a cargo check passes just fine, and I am actually building and running this code currently as part of another program, so it is certain that it does work. In fact, the last version did not have this issue.

My suspicion is that it is incorrectly picking up the first Matrix::zeros(). Nalgebra has four definitions of zeros() on Matrix, each of which may be used depending on which dimensions are Dynamic or which impl DimName.

I will let everyone know if this issue goes away on Monday.

[vadixidav]

The issue still persists, even in the latest release from Monday (which I only installed today).

[vihdzp]

This issue still persists. The following code compiles just fine, but rust-analyzer claims an argument mismatch.

fn main() {
    println!("{}", nalgebra::DMatrix::<i32>::zeros(3, 3));
}

[edwin0cheng]

Seem like this macro invocation expanded incorrectly.

[edwin0cheng]

Wait, there are multiple version of implementation for MatrixMN ...

https://github.com/dimforge/nalgebra/blob/9e625db5382c6eab5541afffe1003f1c512c1edb/src/base/construction.rs

[vadixidav]

This is still occurring to this day. rust-analyzer still seems to be choosing the first implementation on MatrixMN, rather than choosing the correct implementation.

[flodiebold]

#8654 seems to be fixed, but this one still persists. I think the problem is that we don't check trait bounds of the impl during method resolution, so we just choose the first impl.