Skip to content

Code: consider activating the extension lazily #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lnicola opened this issue Feb 21, 2021 · 2 comments
Open

Code: consider activating the extension lazily #7737

lnicola opened this issue Feb 21, 2021 · 2 comments
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement S-actionable Someone could pick this issue up and work on it right now

Comments

@lnicola
Copy link
Member

lnicola commented Feb 21, 2021

We currently set workspaceContains:**/Cargo.toml to have the extension activate if Rust code is present in the workspace, but Code will time out after 5 seconds and activate it anyway.

We could try starting only when editing a Rust file, like vscode-rust did in rust-lang/vscode-rust@61838af.

Thanks to @kankri for the awesome investigation in #2533 (comment), which I've unfortunately missed and to @ishowta who dug it up.

Related #2533
Related #7268

@lnicola lnicola added A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now labels Feb 21, 2021
@taikulawo
Copy link

Any updates in there? It's annoying to showing rust-analyzer failed to discover workspace in no-rust project

@matklad
Copy link
Member

matklad commented Aug 31, 2021

I wonder if we can ask vscode to look for cargo toml only one level deep? I am not a huge fan of loading only when a file is open: I often start with “workspace symbol” request to figure out which file I want opened in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

4 participants