Skip to content

minor: Ignore text and bench attributes again #10044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

minor: Ignore text and bench attributes again #10044

merged 1 commit into from
Aug 27, 2021

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 26, 2021

Reverts part of #9943

@matklad
Copy link
Member

matklad commented Aug 26, 2021

Can we add some test here?

@Veykril
Copy link
Member Author

Veykril commented Aug 26, 2021

A test that checks that we don't expand these for now?

@matklad
Copy link
Member

matklad commented Aug 26, 2021

Not exactly -- a test that basic functionality doesn't break inside #[test]. I guess completion might be the best candidate? Although not sure how to write a test here -- we need to resolve test macro, but not expand it 🤔

@Veykril
Copy link
Member Author

Veykril commented Aug 27, 2021

Would it make sense to only expand the test and bench attributes in tests maybe? That way we can test IDE features in attribute expansions without breaking the user experience in #[test] functions for the time being due to lack of support.

@matklad
Copy link
Member

matklad commented Aug 27, 2021

Yeah, making it configurable is also an option!

@matklad
Copy link
Member

matklad commented Aug 27, 2021

To be clear, I don’t think the retest is absolutely required, but, if something is awkward to test, it might be a sign that we need to think about testing in this specific area more!

@Veykril Veykril force-pushed the rev-extra-attr branch 2 times, most recently from 5c2ac03 to 39d6d1a Compare August 27, 2021 19:52
@Veykril
Copy link
Member Author

Veykril commented Aug 27, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 27, 2021

Build succeeded:

@bors bors bot merged commit 99e67f8 into rust-lang:master Aug 27, 2021
@Veykril Veykril deleted the rev-extra-attr branch August 27, 2021 21:09
@lnicola
Copy link
Member

lnicola commented Aug 28, 2021

71 MB memory win here:

image

@lnicola lnicola mentioned this pull request Sep 10, 2021
Closed
@lnicola lnicola mentioned this pull request May 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Veykril @matklad @lnicola