Skip to content

Pull in new lsp-types for VS compat #10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2021
Merged

Pull in new lsp-types for VS compat #10551

merged 2 commits into from
Oct 18, 2021

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Oct 15, 2021 •
edited
Loading

@lnicola
Copy link
Member Author

lnicola commented Oct 15, 2021 

error[E0599]: no associated item named `Error` found for struct `MessageType` in the current scope
   --> crates/rust-analyzer/src/main_loop.rs:398:69
    |
398 | ...                   lsp_types::MessageType::Error,
    |                                               ^^^^^ associated item not found in `MessageType`

Huh, that's line 115 and it says lsp_types::MessageType::ERROR,.

@lnicola lnicola force-pushed the non-exhaustive-lsp-enums branch 2 times, most recently from adc8801 to 8d4eec8 Compare October 18, 2021 09:00
@lnicola lnicola marked this pull request as ready for review October 18, 2021 09:00
lnicola
lnicola commented Oct 18, 2021
View reviewed changes
crates/rust-analyzer/src/diagnostics/test_data/clippy_pass_by_ref.txt
Comment on lines +26 to +28
DiagnosticSeverity(
2,
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we worried about these? I think it's fine though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that should cause any problems

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't, it's just annoying when you're reading the test baselines.

@lnicola lnicola force-pushed the non-exhaustive-lsp-enums branch from 8d4eec8 to 29d281e Compare October 18, 2021 09:03
@lnicola
Copy link
Member Author

lnicola commented Oct 18, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 18, 2021

Build succeeded:

@bors bors bot merged commit 5ce9b04 into rust-lang:master Oct 18, 2021
@lnicola lnicola deleted the non-exhaustive-lsp-enums branch October 18, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnicola @Veykril