fix: Fix clippy attribute completions always inserting clippy::
#10562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
Veykril
changed the title
clippy::clippy::
|
This isn't specific to clippy, right, it works for any tool lint? |
|
Technically yes, it would need a slight adjustment to actually filter by the path's qualifier(the tool prefix) as it currently just assumes we only complete clippy lints(which is the case for now). |
|
Are you sure that's true? I'm pretty sure I've seen RA completing rustdoc lints. |
|
Ye I'm pretty sure, we don't generate the lint completions for anything other than rustc and clippy currently -> https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide_db/src/helpers/generated_lints.rs |
|
I guess we did before judging from your issue #8349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7144