feat: Switch to LSP inlay hints #11935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
commented
Apr 8, 2022
lnicola
commented
Apr 8, 2022
| @@ -127,8 +127,8 @@ export function joinLines(ctx: Ctx): Cmd { | |||
| ranges: editor.selections.map((it) => client.code2ProtocolConverter.asRange(it)), | |||
| textDocument: ctx.client.code2ProtocolConverter.asTextDocumentIdentifier(editor.document), | |||
| }); | |||
| await editor.edit((builder) => { | |||
| client.protocol2CodeConverter.asTextEdits(items).forEach((edit: any) => { | |||
| await editor.edit(async (builder) => { | |||
There was a problem hiding this comment.
Can we get a cancellation token into the command handlers? There must be a way, but I missed it.
|
bors r+ bors why won't you talk to me? |
bors bot
added a commit
that referenced
this pull request
Apr 9, 2022
11935: feat: Switch to LSP inlay hints r=lnicola a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
|
bors r- |
|
Canceled. |
|
I guess we should way at least until Monday to give people more time to upgrade (although they simply won't get the update instead of ending up with a broken install). |
|
bors r+ |
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.