Skip to content

fix: fix "X is not a valid punct" panic with floats in macros #12231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

fix: fix "X is not a valid punct" panic with floats in macros #12231

merged 1 commit into from
May 12, 2022

Conversation

jonas-schievink
Copy link
Contributor

Should fix #12211

@jonas-schievink jonas-schievink marked this pull request as draft May 12, 2022 16:51
@jonas-schievink jonas-schievink marked this pull request as ready for review May 12, 2022 17:03
@jonas-schievink
Copy link
Contributor Author

Effectively reverts #12185 now, but I'm not sure we can do this in a better way. The MBE conversion code somehow needs to be able to reconstruct which token was a float and which wasn't.

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2022

📌 Commit cb5e8da has been approved by jonas-schievink

@bors
Copy link
Contributor

bors commented May 12, 2022

⌛ Testing commit cb5e8da with merge 0c881e8...

@bors
Copy link
Contributor

bors commented May 12, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 0c881e8 to master...

@bors bors merged commit 0c881e8 into rust-lang:master May 12, 2022
@jonas-schievink jonas-schievink deleted the fix-float-macro-panic branch May 12, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float parsing regression (repeated panic, basically a crash)
2 participants
@jonas-schievink @bors