internal: Bring back JodChild into flychecking for cancellation #12520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad |
matklad
reviewed
Jun 13, 2022
|
Any tips on how I would go about testing the behaviour (in windows to be specific), I haven't fiddled too much with process inspection. |
|
I'd open a project where |
|
Typing doesn't have any effect here though I also don't see why it should be relevant as did change notifications don't touch flycheck, but repeatedly saving a file does kill the process if it is outstanding until no more saving occurs. |
|
@bors r+ |
|
📌 Commit 5979931 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc https://github.com/rust-lang/rust-analyzer/pull/10517/files#r895241975