fix: Simplify macro statement expansion handling #12668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Jul 1, 2022
Veykril
commented
Jul 1, 2022
|
@bors r+ |
|
📌 Commit 8b084cf has been approved by |
|
@bors r+ |
|
📌 Commit e5e5a09 has been approved by |
|
☀️ Test successful - checks-actions |
Merged
|
This brought down our unknown types by a lot (around July 2):
|
|
Oh nice, we do infer types on some more expression now that we didn't look at before so I suppose this makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only meant to fix #12644 but that somehow turned into a rewrite of the statement handling ... at least this fixes a few more issues in the IDE layer now