Skip to content

Conversation

davidbarsky
Copy link
Contributor

I was debugging an unrelated issue in rust-analyzer, but came across this unused code and figured that it's fine to send a fully red PR :)

@Veykril
Copy link
Member

Veykril commented Aug 16, 2022

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Aug 16, 2022

📌 Commit a0b257c has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 16, 2022
…ecking-code, r=Veykril

chore: remove unused `currentExtensionIsNightly()` in `config.ts`

I was debugging an unrelated issue in rust-analyzer, but came across this unused code and figured that it's fine to send a fully red PR :)
@bors
Copy link
Contributor

bors commented Aug 16, 2022

⌛ Testing commit a0b257c with merge 951b2a1...

@bors
Copy link
Contributor

bors commented Aug 16, 2022

💔 Test failed - checks-actions

@davidbarsky
Copy link
Contributor Author

I'm not sure how to get bors to rerun the CI, but that seemed like a transient failure/hiccup.

@lnicola
Copy link
Member

lnicola commented Aug 18, 2022

@bors retry

@bors
Copy link
Contributor

bors commented Aug 18, 2022

⌛ Testing commit a0b257c with merge 917bd68...

@bors
Copy link
Contributor

bors commented Aug 18, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 917bd68 to master...

@bors bors merged commit 917bd68 into rust-lang:master Aug 18, 2022
@davidbarsky davidbarsky deleted the davidbarsky/remove-used-nightly-checking-code branch August 18, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants