feat: add config for inserting must_use in generate_enum_as_method
#13359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Veykril
reviewed
Oct 10, 2022
feniljain
force-pushed
the
feat-must-use-option
branch
from
d46acc9 to
4b44a1d
Compare
|
☔ The latest upstream changes (presumably #13399) made this pull request unmergeable. Please resolve the merge conflicts. |
feniljain
force-pushed
the
feat-must-use-option
branch
3 times, most recently
from
eeb20d3 to
f32e9b6
Compare
feniljain
force-pushed
the
feat-must-use-option
branch
from
f32e9b6 to
c4bdb8e
Compare
Veykril
reviewed
Oct 24, 2022
crates/ide-assists/src/handlers/generate_enum_projection_method.rs
Outdated
Show resolved
Hide resolved
feniljain
force-pushed
the
feat-must-use-option
branch
from
6daf0d9 to
c2bdde9
Compare
feniljain
force-pushed
the
feat-must-use-option
branch
from
c2bdde9 to
4bf9b9b
Compare
|
Weird, ubuntu one passed, but windows one failed |
Veykril
reviewed
Nov 2, 2022
crates/ide-assists/src/handlers/generate_enum_projection_method.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Wirth <[email protected]>
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #13312
Didn't add a test because I was not sure on how to add test for a specific configuration option, tried to look for the usages for other
AssistConfigvariants but couldn't find any intests. If there is a way to test this, do point me towards it.I tried to extract the formatting string as a common
template_stringand only have if-else for that, but it didn't compile :(Also it seems these tests are failing:
Can you also point me to how to correct these 😅 ( I guess there is some command to automatically generate these? )