Skip to content

fix: Don't catch the server activation error #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 20, 2022

We are are rethrowing and showing errors higher up in the call stack already. This just ate the error hiding the stacktrace unnecessarily.

@Veykril Veykril changed the title Don't catch the server activation error fix: Don't catch the server activation error Oct 20, 2022
@Veykril
Copy link
Member Author

Veykril commented Oct 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit 69b8456 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit 69b8456 with merge 32614e2...

@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 32614e2 to master...

@bors bors merged commit 32614e2 into rust-lang:master Oct 20, 2022
@Veykril Veykril deleted the rethrow-err branch October 20, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants