Skip to content

Workaround the python vscode extension's polyfill #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Workaround the python vscode extension's polyfill #13448

merged 1 commit into from
Oct 20, 2022

Conversation

yotamofek
Copy link
Contributor

Fixes #13442

String.replaceAll and String.replace behave the same when given a (/g-flagged) Regex, so fix is very simple.

@Veykril
Copy link
Member

Veykril commented Oct 20, 2022

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit e05df93 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit e05df93 with merge 7741e3d...

@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7741e3d to master...

@bors bors merged commit 7741e3d into rust-lang:master Oct 20, 2022
@yotamofek yotamofek deleted the python-ext-polyfill-workaround branch October 20, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot activate rust-analyzer server: e.replace is not a function
3 participants
@yotamofek @Veykril @bors