Implement location link for type inlay hints #13699
Conversation
rustbot
added
the
S-waiting-on-review
|
@rustbot blocked |
rustbot
added
S-blocked
|
☔ The latest upstream changes (presumably #13804) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The vscode issue is now fixed, but if I understand correctly it will be included in January release, not next release. |
|
Since it won't release until the january release I think we have two options, wait with merging this PR, or check the vscode client version on the server to conditionally enable the link part of this PR as VSCode tells its version in the |
| // FIXME: This is here since it is input of a method in `HirWrite` | ||
| // and things outside of hir need to implement that trait. We probably | ||
| // should move whole `hir_ty::display` to this crate so we will become | ||
| // able to use `ModuleDef` or `Definition` instead of `ModuleDefId`. |
There was a problem hiding this comment.
I think in general we want to have proper visitors for various things at some point, since the HirWrite interface is tailored to IDE purposes right now and shouldn't really be part of hir-ty either.
There was a problem hiding this comment.
I think we should have something in hir-ty that basically turns a type into a tree that directly maps to surface syntax, but still uses IDs instead of names. That representation could then be consumed by the IDE crates
I think it is not necessary, since it wouldn't cause crash or anything like that, it just doesn't do its job. |
I know but I imagine people will start reporting this as a bug. Though maybe its fine if we note this down in the changelog that it current VSCode has a bug there. |
|
Thanks! |
|
☀️ Test successful - checks-actions |
| if let Some(client) = client_info { | ||
| if client.name.contains("Code") || client.name.contains("Codium") { | ||
| if let Some(version) = &client.version { | ||
| if version.as_str() < "1.76" { |
There was a problem hiding this comment.
Shouldn't this be 1.75? 1.74 is the November release, they skip December, and 1.75 comes out in January.
There was a problem hiding this comment.
You are right. I wasn't aware that they will skip december release entirely.
|
VScode has been released January release, could we enable this feature? |
|
It is already enabled |
|
Since #13963. |
fix #11701
This actually doesn't work due a problem in vscode: microsoft/vscode#167564
changelog note: The vscode issue is now fixed, but won't land until the january release, so the feature is disabled serverside for VSCode until then