Skip to content

fix: Watch both stdout and stderr in flycheck #14300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix: Watch both stdout and stderr in flycheck #14300

merged 1 commit into from
Mar 9, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Mar 9, 2023

Fixes #14217

This isn't great because it un-mixes the messages from the two streams, but maybe it's not such a big problem?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2023
Veykril
Veykril approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we can't do much else about this when rustc and cargo don't agree where to output the diagnostics

@lnicola
Copy link
Member Author

lnicola commented Mar 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit 209cf7d has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 9, 2023

⌛ Testing commit 209cf7d with merge 10a652a...

@bors
Copy link
Contributor

bors commented Mar 9, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 10a652a to master...

@bors bors merged commit 10a652a into rust-lang:master Mar 9, 2023
@lnicola lnicola deleted the rustc-flycheck branch March 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flycheck: rustc diagnostics are not read properly
4 participants
@lnicola @bors @Veykril @rustbot