internal: Make inherent_impls_in_block and trait_impls_in_block infallible #14578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
commented
Apr 14, 2023
crates/hir-ty/src/chalk_db.rs
Outdated
| @@ -152,7 +152,8 @@ impl<'a> chalk_solve::RustIrDatabase<Interner> for ChalkContext<'a> { | |||
| impl_maps.into_iter().chain(block_impls).for_each(&mut f); | |||
| def_blocks | |||
| .into_iter() | |||
| .filter_map(|it| self.db.trait_impls_in_block(it?)) | |||
| .filter_map(|it| it) | |||
There was a problem hiding this comment.
I can never remember if the preferred idiom is .filter_map(|it| it) or .flat_map(|it| it) or something else.
There was a problem hiding this comment.
.flatten() should work here as well I think?
lnicola
force-pushed
the
simplify-method-res
branch
from
95e2222 to
febd506
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14574 (comment)