fix: Fix preorder_expr skipping the else block of let-else statements
#14848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes exit/yield points not getting highlighted in such blocks for `highlight_related` (rust-lang#14813; and possibly other bugs in features that use `preorder_expr`).
rustbot
added
the
S-waiting-on-review
bm-w
commented
May 18, 2023
Co-authored-by: Bastiaan Marinus van de Weerd <[email protected]>
|
Thanks! |
Veykril
changed the title
preorder_expr skipping the else block of let-else statementspreorder_expr skipping the else block of let-else statements
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
|
changelog fix (first contribution) traverse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exit/yield points not getting highlighted in such blocks for
highlight_related(#14813; and possibly other bugs in features that usepreorder_expr).