internal: use consistent style for error handling #15087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jun 19, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
HKalbasi
reviewed
Jun 19, 2023
Comment on lines
292
to
298
| impl fmt::Display for VfsPath { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match &self.0 { | ||
| VfsPathRepr::PathBuf(it) => fmt::Display::fmt(&it.display(), f), | ||
| VfsPathRepr::PathBuf(it) => fmt::Debug::fmt(&it, f), | ||
| VfsPathRepr::VirtualPath(VirtualPath(it)) => fmt::Display::fmt(it, f), | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this intentional? I think fmt::Display::fmt(&it, f) is correct here.
There was a problem hiding this comment.
Argh, good catch, this is intentional, but messed up!
In this impl, we want to use Display, in the one below we want to use debug.
that is,
fmt::Debug::fmt(&it.display(),
was actually wrong (this calls display impl, but we do want debug here), but I messed this up.
Could you PR this? :)
bors
added a commit
that referenced
this pull request
Jun 20, 2023
Fix VfsPath Display and Debug impls fix #15087 (comment) r? `@matklad`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.