-
Notifications
You must be signed in to change notification settings - Fork 1.7k
internal: extend check.overrideCommand and buildScripts.overrideCommand docs #15492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…garding invocation strategy and location
They are the same in this regard. The terms are kind of confusing, projects, workspaces, cargo workspaces, vscode workspaces. |
To make things worse, the "root" InvocationLocation is documented as
So this uses "project" in a way very different from I pushed a change which should help elsewhere, but I don't have a good idea for what to do about this one. |
We should probably define some terms and use them appropriately in the docs, as sometimes we do want to talk about the entire opened directory opposed to contained cargo workspace within. I can put that on my homework list |
Damn, now i regret the invocationlocation config option being name |
@bors r+ |
☀️ Test successful - checks-actions |
Extend check.overrideCommand and buildScripts.overrideCommand docs regarding invocation strategy and location.
However something still seems a bit odd -- the docs for
invocationStrategy
/invocationLocation
talk about "workspaces", but the setting that controls which workspaces are considered is calledlinkedProjects
. Is a project the same as a workspace here or is there some subtle difference?