feat: add proc-macro rebuild on save option #16011
Conversation
Signed-off-by: ClSlaid <[email protected]>
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Regarding testing, we don't really have the infra for that yet. So manual testing that it works suffices. https://github.com/rust-lang/rust-analyzer/blob/0840038f02daec6ba3238f05d8caa037d28701a0/docs/dev/debugging.md
You will also need to run the rust-analyzer crate tests to regenerate the config,json
| if self.proc_macro_changed && self.config.script_rebuild_on_save() { | ||
| self.fetch_build_data_queue | ||
| .request_op(format!("proc-macro or build script source changed"), ()) | ||
| } |
There was a problem hiding this comment.
Hmm, so there is a problem with this for us here. Currently we set the proc_macro_changed flag whenever a change comes in for one of the sources, but those changes are not necessarily commited yet (saved), so with the current setup here we would ask for server rebuilds on every keystroke! We should instead move the op request to the DidSaveTextDocument handler (and then also reset the proc_macro_changed flag
Veykril
added
S-waiting-on-author
Signed-off-by: 蔡略 <[email protected]>
|
Thanks! |
|
☀️ Test successful - checks-actions |
Related: #15033
I need some advice on how to test it.