Skip to content

fix: auto remove unnecessary braces after remove unused imports #16066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix: auto remove unnecessary braces after remove unused imports #16066

merged 2 commits into from
Dec 20, 2023

Conversation

Young-Flash
Copy link
Member

before
before

after
after

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2023
@Young-Flash
Copy link
Member Author

could maintainers help review this when have time?

cc @Veykril @lnicola @HKalbasi

lnicola
lnicola approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just wasn't sure that ted is the best API here, but we can probably merge it like this anyway. I'll just wait until tomorrow for a second review.

@lnicola lnicola changed the title feat: auto remove unnecessary braces after remove unused imports fix: auto remove unnecessary braces after remove unused imports Dec 20, 2023
@lnicola
Copy link
Member

lnicola commented Dec 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2023

📌 Commit 4cd939a has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 20, 2023

⌛ Testing commit 4cd939a with merge 65ed198...

@bors
Copy link
Contributor

bors commented Dec 20, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 65ed198 to master...

@bors bors merged commit 65ed198 into rust-lang:master Dec 20, 2023
@bors bors mentioned this pull request Dec 20, 2023
Closed
@Young-Flash Young-Flash deleted the auto_remove_brace branch December 21, 2023 08:01
@lnicola lnicola mentioned this pull request Dec 22, 2023
Closed
@Young-Flash Young-Flash mentioned this pull request Dec 22, 2023
Merged
bors added a commit that referenced this pull request Dec 23, 2023
@bors
Auto merge of #16185 - Young-Flash:fix_auto_remove_brace, r=lnicola
a24ede2 
fix: remove wrong comma after remove unnecessary braces

![remove_comma](https://github.com/rust-lang/rust-analyzer/assets/71162630/56ef8cfc-a024-4c4a-82de-a8cca513b32e)

follow up #16066, close #16181
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Young-Flash @lnicola @bors @Veykril @rustbot