Skip to content

internal: Use Cargo's [workspace.lints.*] to config clippy #16211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
xtask = "run --package xtask --bin xtask --"
tq = "test -- -q"
qt = "tq"
lint = "clippy --all-targets -- -Aclippy::collapsible_if -Aclippy::needless_pass_by_value -Aclippy::nonminimal_bool -Aclippy::redundant_pattern_matching --cap-lints warn"
lint = "clippy --all-targets -- --cap-lints warn"

[target.x86_64-pc-windows-msvc]
linker = "rust-lld"
Expand Down
8 changes: 7 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exclude = ["crates/proc-macro-srv/proc-macro-test/"]
resolver = "2"

[workspace.package]
rust-version = "1.70"
rust-version = "1.74"
edition = "2021"
license = "MIT OR Apache-2.0"
authors = ["rust-analyzer team"]
Expand Down Expand Up @@ -133,3 +133,9 @@ xshell = "0.2.5"

# We need to freeze the version of the crate, as the raw-api feature is considered unstable
dashmap = { version = "=5.5.3", features = ["raw-api"] }

[workspace.lints.clippy]
collapsible_if = "allow"
needless_pass_by_value = "allow"
nonminimal_bool = "allow"
redundant_pattern_matching = "allow"
3 changes: 3 additions & 0 deletions crates/base-db/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ stdx.workspace = true
syntax.workspace = true
vfs.workspace = true
span.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/cfg/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@ derive_arbitrary = "1.3.2"
# local deps
mbe.workspace = true
syntax.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/flycheck/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ command-group.workspace = true
paths.workspace = true
stdx.workspace = true
toolchain.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/hir-def/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@ test-fixture.workspace = true

[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/hir-expand/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ span.workspace = true

[dev-dependencies]
expect-test = "1.4.0"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/hir-ty/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ test-fixture.workspace = true

[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/hir/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ tt.workspace = true

[features]
in-rust-tree = []

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide-assists/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ sourcegen.workspace = true

[features]
in-rust-tree = []

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide-completion/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ expect-test = "1.4.0"
# local deps
test-utils.workspace = true
test-fixture.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide-db/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@ xshell.workspace = true
test-utils.workspace = true
test-fixture.workspace = true
sourcegen.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide-diagnostics/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ sourcegen.workspace = true

[features]
in-rust-tree = []

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide-ssr/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@ expect-test = "1.4.0"
# local deps
test-utils.workspace = true
test-fixture.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/ide/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@ test-fixture.workspace = true

[features]
in-rust-tree = ["ide-assists/in-rust-tree", "ide-diagnostics/in-rust-tree"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/intern/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ dashmap.workspace = true
hashbrown.workspace = true
rustc-hash.workspace = true
triomphe.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/limit/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ rust-version.workspace = true
[features]
tracking = []
default = ["tracking"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/load-cargo/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ vfs-notify.workspace = true
span.workspace = true

hir-expand.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/mbe/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ span.workspace = true

[dev-dependencies]
test-utils.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ sourcegen.workspace = true

[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/paths/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ doctest = false
# serde-derive crate. Even though we don't activate the derive feature here,
# someone else in the crate graph certainly does!
# serde.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/proc-macro-api/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ span.workspace = true
# InternIds for the syntax context
base-db.workspace = true
la-arena.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/proc-macro-srv-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ sysroot-abi = ["proc-macro-srv/sysroot-abi"]
[[bin]]
name = "rust-analyzer-proc-macro-srv"
path = "src/main.rs"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/proc-macro-srv/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ proc-macro-test.path = "./proc-macro-test"

[features]
sysroot-abi = ["proc-macro-test/sysroot-abi"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/profile/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ jemalloc = ["jemalloc-ctl"]

# Uncomment to enable for the whole crate graph
# default = [ "cpu_profiler" ]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/project-model/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ toolchain.workspace = true

[dev-dependencies]
expect-test = "1.4.0"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/rust-analyzer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,6 @@ in-rust-tree = [
"hir-def/in-rust-tree",
"hir-ty/in-rust-tree",
]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/rustc-dependencies/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ ra-ap-rustc_abi = { version = "0.21.0", default-features = false }

[features]
in-rust-tree = []

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/sourcegen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ doctest = false

[dependencies]
xshell.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/span/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ rust-analyzer-salsa.workspace = true
vfs.workspace = true
syntax.workspace = true
stdx.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/stdx/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ winapi = { version = "0.3.9", features = ["winerror"] }
[features]
# Uncomment to enable for the whole crate graph
# default = [ "backtrace" ]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/syntax/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@ sourcegen.workspace = true

[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/syntax/fuzz/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ path = "fuzz_targets/parser.rs"
[[bin]]
name = "reparse"
path = "fuzz_targets/reparse.rs"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/test-fixture/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ base-db.workspace = true
rustc-hash.workspace = true
span.workspace = true
stdx.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/test-utils/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ rustc-hash.workspace = true

stdx.workspace = true
profile.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/text-edit/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ doctest = false
[dependencies]
itertools.workspace = true
text-size.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/toolchain/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ doctest = false

[dependencies]
home = "0.5.4"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/tt/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ stdx.workspace = true

# FIXME: Remove this dependency once the `Span` trait is gone (that is once Span::DUMMY has been removed)
span.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/vfs-notify/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ notify = "6.1.1"
stdx.workspace = true
vfs.workspace = true
paths.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions crates/vfs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ nohash-hasher.workspace = true

paths.workspace = true
stdx.workspace = true

[lints]
workspace = true
3 changes: 3 additions & 0 deletions lib/la-arena/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ documentation = "https://docs.rs/la-arena"
categories = ["data-structures", "memory-management", "rust-patterns"]
edition = "2021"
rust-version = "1.56"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions lib/line-index/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ edition = "2021"
[dependencies]
text-size = "1.1.1"
nohash-hasher = "0.2.0"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions lib/lsp-server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ crossbeam-channel = "0.5.6"
[dev-dependencies]
lsp-types = "=0.95"
ctrlc = "3.4.1"

[lints]
workspace = true
3 changes: 3 additions & 0 deletions xtask/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ xflags = "0.3.0"
time = { version = "0.3", default-features = false }
zip = { version = "0.6", default-features = false, features = ["deflate", "time"] }
# Avoid adding more dependencies to this crate

[lints]
workspace = true