Skip to content

feat: Builtin derives are hygienic #16308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 8, 2024

Closes #16295

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2024
@Veykril Veykril force-pushed the builtin-macro-hygiene branch from b54a4ab to 7dd9f20 Compare January 8, 2024 11:50
@lnicola
Copy link
Member

lnicola commented Jan 8, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit 7dd9f20 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 8, 2024

⌛ Testing commit 7dd9f20 with merge 598511b...

@bors
Copy link
Contributor

bors commented Jan 8, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 598511b to master...

@bors bors merged commit 598511b into rust-lang:master Jan 8, 2024
@Veykril Veykril deleted the builtin-macro-hygiene branch January 8, 2024 17:35
@lnicola
Copy link
Member

lnicola commented Jan 8, 2024

This got rid of all remaining type mismatches on ripgrep:

image

@Veykril Veykril changed the title Builtin derives are hygienic feat: Builtin derives are hygienic Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'No such associated item' when using some structs which derived the 'Default' trait in the crate 'wgpu'
4 participants