-
Notifications
You must be signed in to change notification settings - Fork 1.8k
internal: sync from downstream #16317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b83f487
Set the `in-rust-tree`` feature for all rust-analyzer{-proc-macro-srv…
Veykril ab22869
Imply sysroot-abi feature when in-rust-tree is set
Veykril d480525
Add extern crate rustc_driver to proc-macro-srv-cli
Veykril 8390d2a
Set sysroot-abi flag for proc-macro-cli when in-rust-tree is set
Veykril 79fa976
Set proc-macro-test/sysroot-abi with proc-macro-srv/sysroot-abi
Veykril 3afeb24
Merge commit 'af40101841c45aa75b56f4e9ca745369da8fb4ba' into sync-fro…
lnicola c6a02e3
Merge branch 'release' into sync-from-rust
lnicola f52f2f9
Merge branch 'master' into sync-from-rust
lnicola 0ae7373
Try to fix feature gates
lnicola b0b2b1c
Fix allow(dead_code)
lnicola 4413aeb
Temporarily disable resolve_proc_macro test
lnicola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,14 @@ | |
//! rustc rather than `unstable`. (Although in general ABI compatibility is still an issue)… | ||
|
||
#![cfg(any(feature = "sysroot-abi", rust_analyzer))] | ||
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] | ||
#![feature(proc_macro_internals, proc_macro_diagnostic, proc_macro_span)] | ||
#![warn(rust_2018_idioms, unused_lifetimes)] | ||
#![allow(unreachable_pub, internal_features)] | ||
|
||
extern crate proc_macro; | ||
#[cfg(feature = "in-rust-tree")] | ||
extern crate rustc_driver as _; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is missing a cfg |
||
|
||
mod dylib; | ||
mod server; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -835,7 +835,7 @@ fn main() { | |
#[cfg(any(feature = "sysroot-abi", rust_analyzer))] | ||
fn resolve_proc_macro() { | ||
use expect_test::expect; | ||
if skip_slow_tests() { | ||
if skip_slow_tests() || true { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added an early exit here. |
||
return; | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes