-
Notifications
You must be signed in to change notification settings - Fork 1.8k
internal: Use rustc-hash in more places #16323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ideally we should add a clippy.toml and the disallowed-types lint with that set up to forbid using plain |
Good idea, I forgot that was a thing. It feels like the hardest part is bikeshedding them, e.g. what should we use in |
Hmm, I guess lsp-server is the exception, it should be fine to use in there? |
It also doesn't seem to work very well with derive macros. Anyway, I'll give it a try. |
what derive macros we use emit hashmap related things? 🤔 or was that more a general note, not specific to r-a's codebase |
We have some hashmaps in |
Might as well just replace those with |
I don't remember exactly why that didn't work, they might end up in |
I see, well excluding that module should be fine anyways. |
☔ The latest upstream changes (presumably #16394) made this pull request unmergeable. Please resolve the merge conflicts. |
#16470 supersedes this |
I think there's still
a couplea lot of these left, some in tests and the proc macro server.