fix: use 4 spaces for indentation in macro expansion #16690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
roife
force-pushed
the
fix-issue-16471
branch
from
c6c50ad to
bab167f
Compare
Veykril
reviewed
Feb 27, 2024
| body.syntax() | ||
| .descendants_with_tokens() | ||
| .filter_map(NodeOrToken::into_token) | ||
| .filter(|tok| tok.kind() == SyntaxKind::SELF_KW) |
There was a problem hiding this comment.
That approach won't work, as self can also refer to the current module
There was a problem hiding this comment.
You are right, I forgot the other semantics of self 😱
|
I don't think we can do much about |
Veykril
added
S-waiting-on-author
roife
force-pushed
the
fix-issue-16471
branch
from
bab167f to
4896626
Compare
roife
changed the title
|
I agree that replacement of |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Veykril
approved these changes
Mar 4, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 30, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #16471.
In the previous code, the indentation produced by macro expansion was set to 2 spaces. This PR modifies it to 4 spaces for the sake of consistency.