fix: add a breaker to avoid infinite loops from source root cycles #17412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidhewitt
changed the title
davidhewitt
force-pushed
the
source-loop-cycle-bail
branch
from
c44008d to
0cbf900
Compare
|
Certainly not the way to fix this but it should do for now |
|
Thanks; completely agree that this just hides the problem at the datastructure level but at least it'll save a few watts of energy on users' machines 😂 It also doesn't seem the worst thing to have a way to break out of the infinite loop as an emergency valve. 👀 |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #17409
This patch prevents infinite looping from cycles by giving up if the number of source roots checked for a config value reaches the total number of source roots.
Alternative more precise options include creating a set of all source roots visited and giving up as soon as a cycle is encountered, but I wasn't sure how costly an allocation would be here for performance.
Can confirm that locally this fixes the problem for me.