fix: Properly prevent mir building with unknown types present #18067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
prevent-mir-building
branch
from
a01cfba to
a1ea7f1
Compare
|
@bors r+ |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again. |
bors
added a commit
that referenced
this pull request
Sep 6, 2024
fix: Properly prevent mir building with unknown types present
|
💔 Test failed - checks-actions |
|
Preventing building of all MIR seems too much, we have some IDE features relying on MIR and it'll be a shame if they won't work (or work incorrectly) for incomplete code. Instead, we should be more relaxed in MIR lowering, and allow improper HIR in it. |
Veykril
force-pushed
the
prevent-mir-building
branch
from
a6a9b13 to
d2aa2c0
Compare
I don't disagree but I've been unable to locate the exact cause of us hitting the tuple field requires tuple type |
Veykril
force-pushed
the
prevent-mir-building
branch
from
d2aa2c0 to
0a7d3d8
Compare
Veykril
force-pushed
the
prevent-mir-building
branch
from
0a7d3d8 to
7c52759
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.