Skip to content

internal: add tracing to project discovery and VFS loading #18181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

internal: add tracing to project discovery and VFS loading #18181

merged 1 commit into from
Sep 25, 2024

Conversation

davidbarsky
Copy link
Contributor

With "env RA_PROFILE=vfs_load|parallel_prime_caches|discover_command>500, this results in the following output:

21888ms discover_command
11627ms vfs_load @ total = 701 
1503ms vfs_load @ total = 701 
30211ms parallel_prime_caches

As a followup, I'd like to make hprof emit the information above as JSON.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2024
@ChayimFriedman2
Copy link
Contributor

What's taking so long in vfs_load? What is the repository you're testing with?

@davidbarsky
Copy link
Contributor Author

What's taking so long in vfs_load? What is the repository you're testing with?

It's on an EdenFS-backed private monorepo where I opened Buck2. I talked about some of the issues with Eden in #17537.

(Selfishly: I want some numbers to show as a before/after on any performance work that happens here.)

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2024
@davidbarsky davidbarsky mentioned this pull request Sep 25, 2024
Merged
@davidbarsky davidbarsky force-pushed the davidbarsky/push-nzstpumovmmx branch from b56a183 to 338003f Compare September 25, 2024 14:10
@davidbarsky davidbarsky requested a review from Veykril September 25, 2024 14:10
@davidbarsky
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2024

📌 Commit 338003f has been approved by davidbarsky

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 25, 2024

⌛ Testing commit 338003f with merge df478ea...

@bors
Copy link
Contributor

bors commented Sep 25, 2024

☀️ Test successful - checks-actions
Approved by: davidbarsky
Pushing df478ea to master...

@bors bors merged commit df478ea into rust-lang:master Sep 25, 2024
11 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/push-nzstpumovmmx branch September 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Awaiting requested review from Veykril

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidbarsky @ChayimFriedman2 @bors @Veykril @rustbot