internal: switch remaining OpQueues to use named structs #18216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Oct 14, 2024
|
bors merge |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Oct 14, 2024
…eykril internal: switch remaining OpQueues to use named structs Building atop of #18195, I switched `GlobalState::fetch_build_data_queue` to use a struct instead of a tuple. (I didn't switch `fetch_proc_macros_queue` to not return a bool, as the return value is only used in one spot.)
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
davidbarsky
force-pushed
the
davidbarsky/push-ustyovtqrpoq
branch
from
bc8b860 to
501ef0e
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building atop of #18195, I switched
GlobalState::fetch_build_data_queueto use a struct instead of a tuple.(I didn't switch
fetch_proc_macros_queueto not return a bool, as the return value is only used in one spot.)