Skip to content

chore: rename salsa to ra_salsa #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

chore: rename salsa to ra_salsa #18239

merged 1 commit into from
Oct 14, 2024

Conversation

davidbarsky
Copy link
Contributor

@davidbarsky davidbarsky commented Oct 4, 2024 •
edited
Loading

Laying some groundwork to start before I import the new Salsa crate. Here's why:

  1. As part of the migration, @darichey, @Wilfred, and I will create new Salsa equivalents of the existing databases/query groups. We'll get them to compile crate-by-crate.
  2. Once we wrote all equivalents of all queries, we'd start to refactor usage sites of the vendored Salsa to use the new Salsa databases.
  3. Starting porting usage sites of old Salsa to the new Salsa.
  4. Remove the vendored ra_salsa; declare victory.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2024
Veykril
Veykril reviewed Oct 14, 2024
View reviewed changes
@davidbarsky davidbarsky force-pushed the davidbarsky/push-lswkwuyrpuqv branch from d6e4e9a to ccee36e Compare October 14, 2024 14:11
@davidbarsky
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Oct 14, 2024

📌 Commit ccee36e has been approved by davidbarsky

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 14, 2024

⌛ Testing commit ccee36e with merge 77d4376...

@bors
Copy link
Contributor

bors commented Oct 14, 2024

☀️ Test successful - checks-actions
Approved by: davidbarsky
Pushing 77d4376 to master...

@bors bors merged commit 77d4376 into rust-lang:master Oct 14, 2024
11 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/push-lswkwuyrpuqv branch October 14, 2024 14:35
This was referenced Oct 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla left review comments

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidbarsky @bors @Veykril @ShoyuVanilla @rustbot