Do not consider match/let/ref of place that evaluates to ! to diverge, disallow coercions from them too #18278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Oct 10, 2024
| "#]], | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
We should have a test that make type mismatch error without this PR, but it doesn't emit the error, either with or without this PR.
https://github.com/rust-lang/rust/pull/129392/files#r1746775782
I'll address it as a new issue
ShoyuVanilla
commented
Oct 10, 2024
| @@ -539,3 +539,249 @@ fn test() { | |||
| "#, | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These tests are all of the tests that included in the rustc's original PR, except one case (commented below) and mir ones
ShoyuVanilla
force-pushed
the
never-place
branch
from
963113f to
1f7db21
Compare
Veykril
reviewed
Oct 14, 2024
…, disallow coercions from them too
ShoyuVanilla
force-pushed
the
never-place
branch
from
1f7db21 to
91293ea
Compare
Veykril
approved these changes
Oct 15, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18237