pass struct fields to chalk #19122
pass struct fields to chalk #19122
Conversation
rustbot
added
the
S-waiting-on-review
|
|
||
| fn test() { | ||
| let _: &Foo<[usize]> = &Foo { t: [1, 2, 3] }; | ||
| //^^^^^^^^^^^^^^^^^^^^^ expected &'? Foo<[usize]>, got &'? Foo<[i32; 3]> |
There was a problem hiding this comment.
This test case is effectively the same with the added one, just different kind of coerce unsized
Austaras
force-pushed
the
master
branch
4 times, most recently
from
21fc062 to
c2417cd
Compare
| .collect() | ||
| // HACK: provide full struct type info slows down rust-analyzer by quite a bit unfortunately, | ||
| // so we trick chalk into thinking that our struct impl Unsize | ||
| if let Some(ty) = bound_vars_subst.at(Interner, 0).ty(Interner) { |
There was a problem hiding this comment.
What is the first bound var in this context? (has been a while since I touched this here)
There was a problem hiding this comment.
It's the first generic of this struct
struct Foo<T, U, V>
//^ thisThere was a problem hiding this comment.
Basically this is make chalk believe every struct with generic type is struct Foo<T>(T)
There was a problem hiding this comment.
I wonder if this could cause other issues, also wouldn't this only work out where the first supplied parameter type is actually unsizable?
There was a problem hiding this comment.
I wonder if this could cause other issues
Maybe, but since other tests passed, I guess it's fine so far
also wouldn't this only work out where the first supplied parameter type is actually unsizable?
Yes but I believe r-a and chalk already handled that. r-a has recorded what type is sized and chalk would query r-a for that info.
|
Alright lets give this a test run then, if it doesn't break anything we can keep this as a best effort tradeoff until we switch to the new solver |
|
This is causing major regressions as I expected so we gotta roll this back https://rust-analyzer.github.io/metrics/?start=2025-02-16&end= |
Closes #19003