Skip to content

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 24, 2025

Fixes #19669

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2025
@Veykril Veykril enabled auto-merge April 24, 2025 05:34
@Veykril Veykril disabled auto-merge April 24, 2025 05:42
@ChayimFriedman2
Copy link
Contributor

Please don't merge this yet. I want to review this.

@Veykril
Copy link
Member Author

Veykril commented Apr 24, 2025

Im fine with closing this in favor of yours. This was also meant as a quick and dirty fix for the time being.

@ChayimFriedman2
Copy link
Contributor

So it appears there are more places that we incorrectly don't forward infer_args. I will push all to this PR.

@Veykril
Copy link
Member Author

Veykril commented Apr 24, 2025

Cool go ahead

@ChayimFriedman2
Copy link
Contributor

Okay I did this. I think I covered all places.

@Veykril Veykril enabled auto-merge April 24, 2025 06:13
@Veykril Veykril added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 24, 2025
Veykril and others added 2 commits April 24, 2025 09:16
Previously this being incorrect wasn't a problem, it just meant we put an error type that then changed to infer type, so exactly what rustc does at the end. But now there is a diagnostic.
@Veykril Veykril force-pushed the push-uuluymsosttr branch from 72ee94f to e9fc3b6 Compare April 24, 2025 07:16
@Veykril Veykril added this pull request to the merge queue Apr 24, 2025
Merged via the queue into rust-lang:master with commit 5ff4ba3 Apr 24, 2025
14 checks passed
@Veykril Veykril deleted the push-uuluymsosttr branch April 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect this trait takes 1 generic argument but 0 generic arguments were supplied
3 participants