Skip to content

Shorten inline type hints #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2019
Merged

Shorten inline type hints #1980

merged 3 commits into from
Oct 23, 2019

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Oct 10, 2019

Implements #1946

@detrumi detrumi force-pushed the shorten-inline-type-hints branch from a8c1a6b to 8ab35e9 Compare October 10, 2019 12:52
ice1000
ice1000 reviewed Oct 10, 2019
View reviewed changes
matklad
matklad reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that we've discussed various elaborate ways to do shortenting in the zulip, but I'd love to merge this client-side approach before we do anything really intricate!

@detrumi detrumi force-pushed the shorten-inline-type-hints branch from 8ab35e9 to ce4fb06 Compare October 14, 2019 09:49
@detrumi detrumi force-pushed the shorten-inline-type-hints branch from aa096d4 to 3b61acb Compare October 18, 2019 11:45
@detrumi detrumi marked this pull request as ready for review October 18, 2019 11:46
@detrumi
Copy link
Member Author

detrumi commented Oct 21, 2019

This PR is just the client-side approach now, and is ready for review (replacing parts of the type with {unknown}, and string-replacing that with ? was a bit of a hack anyways)

@detrumi detrumi requested a review from matklad October 21, 2019 12:48
matklad
matklad reviewed Oct 23, 2019
View reviewed changes
@matklad
Copy link
Member

matklad commented Oct 23, 2019 via email

bors bot added a commit that referenced this pull request Oct 23, 2019
@bors @detrumi
Merge #1980
d2e1f9f 
1980: Shorten inline type hints r=matklad a=detrumi

Implements #1946 

Co-authored-by: Wilco Kusee <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 23, 2019

Build succeeded

@bors bors bot merged commit 770bb8d into rust-lang:master Oct 23, 2019
@detrumi detrumi deleted the shorten-inline-type-hints branch October 23, 2019 11:30
@bjorn3 bjorn3 mentioned this pull request Apr 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore left review comments

@ice1000 ice1000 ice1000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@detrumi @matklad @SomeoneToIgnore @ice1000