Skip to content

Flag to hide cargo.toml not found error #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 9, 2020
Merged

Flag to hide cargo.toml not found error #2732

merged 6 commits into from
Jan 9, 2020

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Jan 3, 2020 •
edited
Loading

Implements #2533

This adds a notifications.cargo-toml-not-found feature flag. Though we could also re-use notifications.workspace-loaded instead?

Also hides the "workspace loaded" message when 0 packages were loaded seems like this wasn't a good idea after all, somehow this causes test_runnables_project to break

@detrumi detrumi force-pushed the cargo-toml-not-found-message-toggle branch from 415b39b to 6c321d7 Compare January 3, 2020 13:34
@detrumi detrumi changed the title WIP: Flag to toggle workspace loaded message Flag to toggle workspace loaded message Jan 3, 2020
@detrumi detrumi marked this pull request as ready for review January 3, 2020 14:39
@detrumi detrumi force-pushed the cargo-toml-not-found-message-toggle branch from 98d6e97 to e7bb82c Compare January 3, 2020 14:49
kiljacken
kiljacken suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@kiljacken kiljacken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but am I missing something or is the title of the PR wrong? This seems to be mostly a workspace error overhaul, and doesn't actual touch the workspace-loaded message.

@detrumi
Copy link
Member Author

detrumi commented Jan 6, 2020

The code looks good to me, but am I missing something or is the title of the PR wrong? This seems to be mostly a workspace error overhaul, and doesn't actual touch the workspace-loaded message.

Oh right, the title should've been about the ability to hide the Cargo.toml not found error

@detrumi detrumi changed the title Flag to toggle workspace loaded message Flag to hide cargo.toml not found error Jan 6, 2020
kiljacken
kiljacken approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@kiljacken kiljacken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case it looks good to me! Good job 👍

@detrumi detrumi force-pushed the cargo-toml-not-found-message-toggle branch from 3ee89f6 to 003620f Compare January 8, 2020 13:06
detrumi and others added 2 commits January 8, 2020 17:21
@matklad
Copy link
Member

matklad commented Jan 8, 2020

bors r+

Thanks!

@kjeremy
Copy link
Contributor

kjeremy commented Jan 9, 2020

Looks like bors didn't take it

@matklad matklad merged commit cf5bdf4 into rust-lang:master Jan 9, 2020
@detrumi detrumi deleted the cargo-toml-not-found-message-toggle branch January 9, 2020 14:21
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

@kiljacken kiljacken kiljacken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@detrumi @matklad @kjeremy @kiljacken