Disable rollup warning #3158
Merged
Disable rollup warning #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did investigate this a bit some time ago. Created an issue under rollup repo rollup/rollup#3368. I think we should not get this warning with default settings in any way, though disabling it this way is an option, I have nothing against... |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 15, 2020
3158: Disable rollup warning r=matklad a=edwin0cheng In https://rollupjs.org/guide/en/#output-exports ``` As with regular entry points, files that mix default and named exports will produce warnings. You can avoid the warnings by forcing all files to use named export mode via output.exports: "named". ``` This PR try added `output.exports: "named"` and disabe this warning. It is because vscode consume our plugins only by named functions such that it should be saved to disable it. cc @Veetaha Co-authored-by: Edwin Cheng <[email protected]>
Build succeeded
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://rollupjs.org/guide/en/#output-exports
This PR try added
output.exports: "named"and disabe this warning. It is because vscode consume our plugins only by named functions such that it should be safe to disable it.cc @Veetaha