Cleanup proc_macro config #4102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Apr 23, 2020
4102: Cleanup proc_macro config r=matklad a=matklad In general, there should be no reason to call `.to_string_lossy`. If you want to display the path, use `.display()`. If you want to pass the path to an OS API (like std::process::Command) than use `PathBuf` or `OsString`. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
|
cc @edwin0cheng |
lnicola
reviewed
Apr 23, 2020
| @@ -694,13 +694,10 @@ pub fn foo(_input: TokenStream) -> TokenStream { | |||
| .with_config(|config| { | |||
| // FIXME: Use env!("CARGO_BIN_EXE_ra-analyzer") instead after | |||
lnicola
approved these changes
Apr 23, 2020
In general, there should be no reason to call `.to_string_lossy`. If you want to display the path, use `.display()`. If you want to pass the path to an OS API (like std::process::Command) than use `PathBuf` or `OsString`.
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, there should be no reason to call
.to_string_lossy.If you want to display the path, use
.display().If you want to pass the path to an OS API (like std::process::Command)
than use
PathBuforOsString.bors r+
🤖