Skip to content

Check client capabilities before sending progress notifications #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

Check client capabilities before sending progress notifications #4403

merged 1 commit into from
May 11, 2020

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented May 9, 2020

Fixes #4384

@kjeremy kjeremy mentioned this pull request May 11, 2020
Closed
@matklad
Copy link
Member

matklad commented May 11, 2020

bors d+

👍

@bors
Copy link
Contributor

bors bot commented May 11, 2020

✌️ kjeremy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kjeremy
Copy link
Contributor Author

kjeremy commented May 11, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 11, 2020

Build succeeded:

@bors bors bot merged commit de1fe23 into rust-lang:master May 11, 2020
@kjeremy kjeremy deleted the progress-check branch May 11, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress reporting should respect client capabilities
2 participants
@kjeremy @matklad