More type inference for more binary expressions #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just for primitive numeric types such as u32 and f64. Not yet a general solution using trait resolution.
flodiebold
reviewed
Jan 7, 2019
crates/ra_hir/src/ty.rs
Outdated
| @@ -529,15 +529,40 @@ struct InferenceContext<'a, D: HirDatabase> { | |||
|
|
|||
| // helper function that determines whether a binary operator | |||
| // always returns a boolean | |||
| fn is_boolean_operator(op: BinaryOp) -> bool { | |||
| fn boolean_op_return_ty(op: BinaryOp, rhs_ty: Ty) -> Ty { | |||
There was a problem hiding this comment.
this should be called binary_op_return_ty, right? it's not just for boolean ops. Also, the comment is outdated
crates/ra_hir/src/ty.rs
Outdated
| let lhs_ty = self.infer_expr(*lhs, &lhs_expectation)?; | ||
| // TODO: find implementation of trait corresponding to operation | ||
| // symbol and resolve associated `Output` type | ||
| let rhs_expectation = match op { |
There was a problem hiding this comment.
maybe this big match could also be extracted into a function
There was a problem hiding this comment.
Good idea. Will do.
| } | ||
| "#, | ||
| "boolean_op.txt", | ||
| "binary_op.txt", |
There was a problem hiding this comment.
it seems you forgot to add the renamed file?
There was a problem hiding this comment.
uhh, I forgot to add it to git I think! 😨
|
Thanks again for the review and apologies for the sloppy mistakes - I will try to do better! |
|
No problem, thank you 😄 bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 7, 2019
451: More type inference for more binary expressions r=flodiebold a=marcusklaas Implements more of #390. Just works for primitive (numeric) types for now. Found an issue where `let x: Ty = expr;` doesn't actually propagate the type information unless `Ty` is primitive and numeric. I'll open an issue for this. Co-authored-by: Marcus Klaas de Vries <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements more of #390. Just works for primitive (numeric) types for now.
Found an issue where
let x: Ty = expr;doesn't actually propagate the type information unlessTyis primitive and numeric. I'll open an issue for this.