Skip to content

Bump some dependencies #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2020
Merged

Bump some dependencies #4574

merged 4 commits into from
May 24, 2020

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented May 22, 2020

No description provided.

@matklad
Copy link
Member

matklad commented May 22, 2020

bors r+

bors bot added a commit that referenced this pull request May 22, 2020
4574: Bump some dependencies r=matklad a=lnicola



Co-authored-by: Laurențiu Nicola <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 22, 2020

Canceled.

@lnicola
Copy link
Member Author

lnicola commented May 22, 2020

Ah, I didn't get the notification for the r+. The latest commit upgrades some npm packages and eslint complains a little about the TypeScript version. Do we care about that?

@lnicola
Copy link
Member Author

lnicola commented May 22, 2020

Actually, I think it was complaining even before my changes (we were already on 3.9).

@lnicola
Copy link
Member Author

lnicola commented May 23, 2020

r? @kjeremy

@lnicola
Copy link
Member Author

lnicola commented May 24, 2020

Rebased.

@matklad
Copy link
Member

matklad commented May 24, 2020

bors d+

@bors
Copy link
Contributor

bors bot commented May 24, 2020

✌️ lnicola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@lnicola
Copy link
Member Author

lnicola commented May 24, 2020

bors r+

...I guess

@lnicola
Copy link
Member Author

lnicola commented May 24, 2020

Oof...

@matklad r=matklad

@matklad matklad merged commit c1a7f74 into rust-lang:master May 24, 2020
@matklad
Copy link
Member

matklad commented May 24, 2020

Build succeeded:

@lnicola lnicola deleted the bump-deps branch May 24, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants