Skip to content

Parse default unsafe & default const #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2020
Merged

Parse default unsafe & default const #4737

merged 4 commits into from
Jun 4, 2020

Conversation

Avi-D-coder
Copy link
Contributor

Closes: #4718 #4264

@lnicola lnicola mentioned this pull request Jun 4, 2020
Merged
matklad
matklad reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo test placement.

@Avi-D-coder Avi-D-coder requested a review from matklad June 4, 2020 17:07
@matklad
Copy link
Member

matklad commented Jun 4, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 4, 2020

Build succeeded:

@bors bors bot merged commit e66c7b3 into rust-lang:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad Awaiting requested review from matklad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default unsafe impl erroneously is a syntax error
2 participants
@Avi-D-coder @matklad