Smaller inlay hints

[kjeremy]

This makes things a lot more readable but isn't officially supported by vscode: microsoft/vscode#9078

Inspired by Visual Studio, IntelliJ and Resharper.

[kjeremy]

[SomeoneToIgnore]

Looks really nice actually.

bors r+

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)

[lnicola]

Great, CSS injection. But is text-decoration:; valid CSS? You dropped the none.

[kjeremy]

@inicola I took it from the linked issue: microsoft/vscode#9078 (comment)

[bjorn3]

CSS ignores invalid declarations.

[lnicola]

Then this might have undone #6392.

[matklad]

Glorious!

[mcarton]

Is this configurable? This is something I've always hated in Visual Studio.

[kjeremy]

It is not currently but PRs are welcome.

…

On Mon, Nov 2, 2020 at 10:46 AM Martin Carton ***@***.***> wrote: Is this configurable? This is something I've always hated in Visual Studio. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6394 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBACRBKT2HORSGG6X3VIZTSN3H6LANCNFSM4TCLLFMA> .

[qm3ster]

I think it's causing misalignment of ▶ Run Test | Debug decoration:


for example when zooming with "editor.mouseWheelZoom": true

[lnicola]

@qm3ster that's a code lens and is drawn by Code, you should probably file a bug there:

[qm3ster]

@lnicola my bad, I thought it started with this commit.
Are these inlay hints not considered code lens in terms of vscode?

[SomeoneToIgnore]

inlay hints are implemented via vscode decorations, which is a different thing form the code lens.

The PR we're commenting under had edited the particular place in the file where those decorations are created, if you're interested to see the code.