Node-ify lifetimes #6896
Node-ify lifetimes #6896
Conversation
Refactors builtin derive support to go through proper name resolution
|
bors d+ here as well @Veykril feel free to merge this and the correspoinding ungrammar PR as soon as you'll have time! |
|
✌️ Veykril can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Rebased on top of #6897 as this PR will get conflicts from that for sure(the bors merge commit from that PR shouldn't affect this PR once its merged I think right?) due to Cargo.lock and the generated syntax files. |
Cargo.toml
Outdated
| @@ -16,7 +16,7 @@ text-size.opt-level = 3 | |||
| miniz_oxide.opt-level = 3 | |||
|
|
|||
| [profile.release] | |||
| incremental = true | |||
| incremental = true | |||
There was a problem hiding this comment.
Oh, for some reason whatever formats that in vscode for me adds that in and I'm not sure why 😅
There was a problem hiding this comment.
One of these days, I'll make a proper lossless toml library...
There was a problem hiding this comment.
There actually is a lossless toml library in rust(it even uses rowan) https://github.com/tamasfe/taplo and I just noticed I use the vscode extension of that but it seems the formatter for that doesn't play nicely yet.
There was a problem hiding this comment.
Strange, Even Better TOML works fine for me (with some consistent config tweaking).
|
bors r+ |
Let's see if this passes the tests 🤞
Depends on rust-analyzer/ungrammar#15