Skip to content

Limit the hints size by default #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2021
Merged

Limit the hints size by default #8177

merged 2 commits into from
Mar 24, 2021

Conversation

SomeoneToIgnore
Copy link
Contributor

Fixes #8175
Fixes #3138

@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Mar 23, 2021
Closed
@Veykril
Copy link
Member

Veykril commented Mar 23, 2021

20 is a bit too short imo, reason being that our impl Iterator<Item = > trick for hints becomes completely useless as the inner type will always be hidden giving impl Iterator<Item = ...> since the template string is already greater than 20 characters. I personally have been using 25 which works reasonably well which I would also propose

@lnicola
Copy link
Member

lnicola commented Mar 23, 2021

changelog fix

@SomeoneToIgnore
Copy link
Contributor Author

bors r=Veykril

@bors
Copy link
Contributor

bors bot commented Mar 24, 2021

Build succeeded:

@bors bors bot merged commit 5f9ba2d into rust-lang:master Mar 24, 2021
@SomeoneToIgnore SomeoneToIgnore deleted the limited-hints branch March 24, 2021 09:21
@aspeddro aspeddro mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saner default for inlayHints.maxLength config parameter Optimize the user experience when line gets too long after inlay hints are inserted.
3 participants
@SomeoneToIgnore @Veykril @lnicola